Test pull#10
Closed
nachocano wants to merge 316 commits into
Closed
Conversation
Broker unit tests.
Trigger filters on event source and type
spec is immutable.
…dType. Add unit tests for the filter binary.
Rename Trigger.Spec.Filter.ExactMatch to Trigger.Spec.Filter.SourceAndType. Add unit tests for the filter binary.
With this we allow to reconcile only the triggers that belong to the particular broker that changed
Reconcile Triggers on Broker changes.
Trigger controller UTs
…eAccount and RBAC. Sadly this doesn't work well because we have such an old version of controller-runtime that the Filter ends up trying to watch _all_ Triggers, not just those in its namespace. And it only gets permission for the Triggers in its own namespace.
Should be implemented
Broker and trigger types UTs
# Conflicts: # cmd/broker/ingress/main.go
# Conflicts: # Gopkg.lock
# Conflicts: # cmd/controller/main.go # pkg/reconciler/v1alpha1/namespace/namespace.go # pkg/reconciler/v1alpha1/namespace/namespace_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dummy PRr