Skip to content

Update sdk usage for client #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nachocano merged 1 commit into from
Mar 29, 2019
Merged

Update sdk usage for client #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions pkg/broker/receiver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ import (
)

const (
defaultPort = 8080

writeTimeout = 1 * time.Minute
)

Expand All @@ -44,17 +42,12 @@ type Receiver struct {
logger *zap.Logger
client client.Client
ceClient ceclient.Client
ceHTTP *cehttp.Transport
}

// New creates a new Receiver and its associated MessageReceiver. The caller is responsible for
// Start()ing the returned MessageReceiver.
func New(logger *zap.Logger, client client.Client) (*Receiver, error) {
ceHTTP, err := cehttp.New(cehttp.WithBinaryEncoding(), cehttp.WithPort(defaultPort))
if err != nil {
return nil, err
}
ceClient, err := ceclient.New(ceHTTP)
ceClient, err := ceclient.NewDefault()
if err != nil {
return nil, err
}
Expand All @@ -63,7 +56,6 @@ func New(logger *zap.Logger, client client.Client) (*Receiver, error) {
logger: logger,
client: client,
ceClient: ceClient,
ceHTTP: ceHTTP,
}
err = r.initClient()
if err != nil {
Expand Down Expand Up @@ -204,7 +196,7 @@ func (r *Receiver) sendEvent(ctx context.Context, tctx cehttp.TransportContext,
}

sendingCTX := SendingContext(ctx, tctx, subscriberURI)
return r.ceHTTP.Send(sendingCTX, *event)
return r.ceClient.Send(sendingCTX, *event)
}

func (r *Receiver) getTrigger(ctx context.Context, ref provisioners.ChannelReference) (*eventingv1alpha1.Trigger, error) {
Expand Down