Skip to content

Conversation

@savar
Copy link

@savar savar commented Apr 20, 2024

trying to update all relevant dependencies to have no audit issues anymore

see issue #41

trying to update all relevant dependencies to have no audit issues
anymore
@savar
Copy link
Author

savar commented Apr 20, 2024

Please be aware, I am no expert in Javascript's world of madness. I tried to update as good and as sane as I could but honestly I am just poking in the dark.

  • it is now using some experimental features for ESM modules, as otherwise the tests didn't run at all
  • I adjusted the tests only in two small places to keep them working, so I don't know if this means that everything is good or that the tests aren't able to find all the issues.. I hope it is the first one though
  • some dependencies complain about node20 not being supported locally on my machine, but as I am not experienced enough on this one, I don't know if this is okay or not, but updating them will start a dependency war and I wasn't able in a quick check to fix this 🤷‍♂️
  • yarn build complains now about some circular dependencies which it didn't do before as far as I can remember, but it still runs through
  • using this module locally allows me to still see a simple hill chart in my project.. for what its worth

Somebody with much more experience should have a look regarding the changes, if they do make sense or not!

@savar
Copy link
Author

savar commented May 3, 2024

Anything required from my end to get this checked and maybe merged/deployed?

@nagi1
Copy link
Owner

nagi1 commented May 24, 2024

Hey thank you so much for taking the time to take care of this.

But I can't merge pr that we are not sure about, im really struggling to find time to do it. Can we rely on other community members to look at this?

@savar
Copy link
Author

savar commented Jun 1, 2024

Hey thank you so much for taking the time to take care of this.

But I can't merge pr that we are not sure about, im really struggling to find time to do it. Can we rely on other community members to look at this?

I would love to help, but I am normally not running in the JavaScript world. Maybe you know someone. I can only tell you, that it seems to work fine and the test work.

@savar
Copy link
Author

savar commented Sep 6, 2024

Any plans to merge this? In the worst case, we can release this with a major version jump so that no one is using it without being aware of the potential issue that it might break (though the tests and my local system say otherwise)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants