-
Notifications
You must be signed in to change notification settings - Fork 0
feat: list activities in Activity Inventory #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I implemented the `activity list` command to display all active activities in the Activity Inventory. Activities are sorted by their priority and creation date. I refactored the source code to put the subcommands into their own subdirectories. I moved the context code to its own package to resolve a circular dependency error.
🐳 Container Image BuiltYour PR container image has been built and published: Supported architectures: linux/amd64, linux/arm64 Usage: docker run --rm ghcr.io/nakedsoftware/time:pr-45 --help
|
I renamed start_pomodoro_command.go to start_command.go to match the naming convention that I am using for other commands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements the activity list command to display all active activities from the Activity Inventory, with activities sorted by priority and creation date. The code has been refactored to organize subcommands into their own subdirectories and resolve circular dependency issues.
- Moved context management code to a separate package to resolve circular dependencies
- Reorganized CLI subcommands into dedicated subdirectories (activity, pomodoro)
- Added new
activity listcommand with database querying and output formatting
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/context/context.go | Extracted context utilities to separate package, added database context functions |
| internal/cli/root_command.go | Updated to use new context package |
| internal/cli/pomodoro/start_command.go | Moved to pomodoro subdirectory, updated imports and variable names |
| internal/cli/execute.go | Updated command registration to use reorganized subcommand structure |
| internal/cli/activity/list_command.go | New command implementation for listing activities with database queries |
| internal/cli/activity/add_command.go | Moved to activity subdirectory, updated imports and variable names |
Files not reviewed (2)
- .idea/fileTemplates/internal/Go Application.go: Language not supported
- .idea/fileTemplates/internal/Go File.go: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
🐳 Container Image BuiltYour PR container image has been built and published: Supported architectures: linux/amd64, linux/arm64 Usage: docker run --rm ghcr.io/nakedsoftware/time:pr-45 --help
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
🐳 Container Image BuiltYour PR container image has been built and published: Supported architectures: linux/amd64, linux/arm64 Usage: docker run --rm ghcr.io/nakedsoftware/time:pr-45 --help
|
I implemented the
activity listcommand to display all active activities in the Activity Inventory. Activities are sorted by their priority and creation date.I refactored the source code to put the subcommands into their own subdirectories. I moved the context code to its own package to resolve a circular dependency error.
Closes #40