-
Notifications
You must be signed in to change notification settings - Fork 15
docs(ensnode): update hosted instances list #1580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
📝 WalkthroughWalkthroughDocumentation updated to use a path-based admin connection URL ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the hosted ENSNode instances documentation by adding a new ENS V2 Sepolia instance and correcting the URL format for all connection links.
Changes:
- Fixed connection URLs to include
/connectionpath segment for all 4 existing instances (Alpha, Alpha-Sepolia, Mainnet, Sepolia) - Added new "ENS V2 Deployments" section with ENSNode v2 Sepolia instance
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Greptile OverviewGreptile SummaryThis PR adds documentation for the new ENS V2 Sepolia hosted instance and fixes URL paths for ENSAdmin connection links across all existing instances. Changes:
Impact: Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Docs as Documentation Site
participant Admin as ENSAdmin UI
participant API as ENSNode API Instance
Dev->>Docs: Browse hosted instances page
Docs->>Dev: Display instance list with URLs
Dev->>Docs: Click "Connect with ENSAdmin" button
Docs->>Admin: Navigate to /connection page with instance URL
Admin->>API: Connect to specified ENSNode instance
API->>Admin: Return instance data and capabilities
Admin->>Dev: Display connected instance interface
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
lightwalker-eth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tk-o Thanks! Just 2 small suggestions. Please merge when ready 👍
| <HostedEnsNodeInstances | ||
| instanceURL="https://api.alpha.ensnode.io" | ||
| connectWithENSAdminURL="https://admin.ensnode.io?connection=https%3A%2F%2Fapi.alpha.ensnode.io" | ||
| connectWithENSAdminURL="https://admin.ensnode.io/connection?connection=https%3A%2F%2Fapi.alpha.ensnode.io" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tk-o Nice work catching this. Thanks!
|
|
||
| ### ENS V2 Deployments | ||
|
|
||
| These ENSNode instances focus on future-proofing ENS indexing with ENS V2 support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| These ENSNode instances focus on future-proofing ENS indexing with ENS V2 support. | |
| These instances demonstrate the latest ENSv2 support in ENSNode. |
| connectWithENSAdminURL="https://admin.ensnode.io/connection?connection=https%3A%2F%2Fapi.v2-sepolia.ensnode.io" | ||
| namespace="sepolia" | ||
| plugins="ensv2, protocol-acceleration" | ||
| purpose="Demonstration of ENSNode's future-proofing with ENS V2 support." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| purpose="Demonstration of ENSNode's future-proofing with ENS V2 support." | |
| purpose="Preview of ENSNode's ENSv2 support on the Sepolia deployment of ENSv2." |
Lite PR
Tip: Review docs on the ENSNode PR process
Summary
Why
Testing
Notes for Reviewer (Optional)
Pre-Review Checklist (Blocking)