Skip to content

Fixing chip select#37

Merged
josesimoes merged 1 commit intodevelopfrom
fix-chipselect
Jul 16, 2021
Merged

Fixing chip select#37
josesimoes merged 1 commit intodevelopfrom
fix-chipselect

Conversation

@Ellerbach
Copy link
Copy Markdown
Member

@Ellerbach Ellerbach commented Jul 16, 2021

Description

Fixing issue with Chip Select not properly working

Motivation and Context

  • Fixes issue with Chip Select

How Has This Been Tested?

On a real device

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot nfbot added the Type: bug Something isn't working label Jul 16, 2021
Copy link
Copy Markdown
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finding! This one was tricky!

@josesimoes josesimoes enabled auto-merge July 16, 2021 14:57
@josesimoes josesimoes disabled auto-merge July 16, 2021 14:57
@josesimoes josesimoes enabled auto-merge (squash) July 16, 2021 14:57
@josesimoes josesimoes merged commit 35927ed into develop Jul 16, 2021
@nfbot nfbot added invalid This doesn't seem right and removed Type: bug Something isn't working labels Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants