ES CDS defines two nearly identically-named constants with different values #370
Description
Describe the bug
The CDS code uses two mission-scope configuration values:
CFE_MISSION_ES_CDS_MAX_NAME_LENGTH
CFE_MISSION_ES_CDS_MAX_NAME_LEN
The values are actually different; the "LENGTH" version is just the CDS base name, where as the "LEN" is the size of the qualified name (APP.CDSName form).
To Reproduce
No runtime issue, this is a style/maintenance issue.
Expected behavior
The names should be more different and distinctive.
Suggest that CFE_MISSION_ES_CDS_MAX_NAME_LENGTH should be renamed to indicate that it reflects the size of the base name only. This value appears to primarily be used internally to CDS, and does not get directly used in telemetry packets, so it would be easier to rename, with less impact on existing code.
Reporter Info
Joseph Hickey, Vantage Systems, Inc.