LGTM issue - integer comparison size mismatch #831
Description
Is your feature request related to a problem? Please describe.
/* send an event for each pipe write error that may have occurred */
--
1489 | for(i=0;i < SBSndErr.EvtsToSnd; i++)
| Comparison between i of type uint16 and EvtsToSnd of wider type uint32.
1490 | {
1491 | if(SBSndErr.EvtBuf[i].EventId == CFE_SB_MSGID_LIM_ERR_EID)
In theory if EvtsToSend is > max uint16 this could infinite loop. Pretty unlikely, but definitely shouldn't be in flight code.
Describe the solution you'd like
i should be sized appropriately
Describe alternatives you've considered
None
Additional context
Split off from #431
Requester Info
Jacob Hageman - NASA/GSFC