Remove/replace/deprecate questionable macros in SB

[skliper]

Is your feature request related to a problem? Please describe.

cFE/fsw/cfe-core/src/inc/cfe_sb.h

Lines 122 to 138 in 06c0826

	/**
	* \brief Set memory address within SB Message
	*
	* Macro that should be used to set memory addresses within software bus messages.
	* For now this does a straight copy, but in a future revision this may translate the
	* raw memory address into a "safe" integer value. This is particularly important if
	* the message is to be sent off this CPU.
	*/
	#define CFE_SB_SET_MEMADDR(msgdst,src) msgdst = (cpuaddr)src
	/**
	* \brief Get memory address from SB Message
	*
	* Macro that should be used to get memory addresses from software bus messages.
	* This is the inverse operation of CFE_SB_SET_MEMADDR.
	*/
	#define CFE_SB_GET_MEMADDR(msgsrc) (cpuaddr)msgsrc

Describe the solution you'd like
Consider replacing or removing (deprecating).

Describe alternatives you've considered
None

Additional context
Trying to write specific tickets related to #172

Requester Info
Jacob Hageman - NASA/GSFC

[skliper]

@jphickey do you have background on these? I only see CFE_SB_GET_MEMADDR used in CFE_ES_SendMemPoolStatsCmd, which I assume will go away once that's updated to use a reference. Should CFE_SB_SET_MEMADDR be an inline function... or what's the concept behind it? I'm not sure what a "safe" memory address is...

[skliper]

Fixed by #1003