issue #425, resolve cpp check #432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
suggested changes
Dec 30, 2019
fsw/cfe-core/src/sb/cfe_sb_util.c
Outdated
Comment on lines
112
to
113
| /* cppcheck-suppress unusedVariable */ | ||
| uint16 size; | ||
|
|
||
| #ifdef MESSAGE_FORMAT_IS_CCSDS |
Contributor
There was a problem hiding this comment.
Can suppression be removed if uint16 size; is inside #ifdef?
fsw/cfe-core/src/sb/cfe_sb_priv.c
Outdated
Comment on lines
708
to
709
| /* cppcheck-suppress unreadVariable */ | ||
| CFE_SB_MsgId_Atom_t Val = MsgId; | ||
|
|
||
| #ifdef MESSAGE_FORMAT_IS_CCSDS |
Contributor
There was a problem hiding this comment.
Can suppression be removed if line is moved within ifdef?
fsw/cfe-core/src/sb/cfe_sb_init.c
Outdated
| /* cppcheck-suppress unusedVariable */ | ||
| CFE_SB_MsgKey_Atom_t KeyVal; | ||
|
|
||
| #ifdef MESSAGE_FORMAT_IS_CCSDS |
Contributor
There was a problem hiding this comment.
Can suppression be removed if line is within ifdef?
CDKnightNASA
approved these changes
Jan 7, 2020
Contributor
CDKnightNASA
left a comment
CDKnightNASA
left a comment
There was a problem hiding this comment.
Looks good to me. Always prefer initializing variables at declaration time.
Contributor
Author
|
updated. |
skliper
approved these changes
Jan 8, 2020
skliper
added
the
CCB:Approved
Contributor
|
CCB 20190108 - Reviewed and approved for integration candidate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
resolve cpp check
Testing performed
Steps taken to test the contribution:
System(s) tested on:
Additional context
Add any other context about the contribution here.
Contributor Info
Anh Van, NASA Goddard