Skip to content

Conversation

@skliper
Copy link
Contributor

@skliper skliper commented Apr 28, 2020

Describe the contribution
Deletes now unused CFE_ES_CountObjectCallback
and CFE_ES_ListResourcesDebug.
Fix #639

Testing performed
CI - https://travis-ci.com/github/skliper/cFS/builds/162476743

Expected behavior changes
None, flag was undefined

System(s) tested on

  • Hardware: CI
  • OS: Ubuntu 18.04
  • Versions: Master bundle + this branch

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added enhancement CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Apr 28, 2020
@skliper skliper added this to the 6.8.0 milestone Apr 28, 2020
@skliper skliper force-pushed the fix639-es-app-debug branch from d264cb3 to 8de3ab9 Compare April 28, 2020 16:34
@skliper
Copy link
Contributor Author

skliper commented Apr 28, 2020

Force pushed unit test fixes

@astrogeco
Copy link
Contributor

CCB 2020-04-29 : APPROVED

@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB CCB-20200429 and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels May 5, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate May 8, 2020 18:04
@astrogeco
Copy link
Contributor

@skliper can you resolve the conflicts?

Deletes now unused CFE_ES_CountObjectCallback
and CFE_ES_ListResourcesDebug.
@skliper skliper force-pushed the fix639-es-app-debug branch from 8de3ab9 to 9cb0b5d Compare May 8, 2020 20:39
@skliper
Copy link
Contributor Author

skliper commented May 8, 2020

@astrogeco resolved

@skliper skliper removed the conflicts label May 8, 2020
@astrogeco astrogeco merged commit 10e7f81 into nasa:integration-candidate May 8, 2020
skliper pushed a commit to skliper/cFE that referenced this pull request May 11, 2020
Fix nasa#639, Remove ES_APP_DEBUG functionality
@skliper skliper deleted the fix639-es-app-debug branch February 1, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CCB:Approved Indicates code review and approval by community CCB enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove ES_APP_DEBUG ifdef and related code

2 participants