Integration Candidate: 2020-05-27 #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add string validation to the sample event hook as an example of how to use the context information supplied to the hook to perform other validation.
Applications should only use types provided by CFE_SB.
Fix #66, Add extended context information to event hook
Fix #68, remove references to CCSDS types
Contributor
Author
|
@jphickey nasa/cFS#96 has some build errors related to building sample_app and sample_lib unit tests can you help? |
Should use CFE_MISSION_EVS_MAX_MESSAGE_LENGTH
Contributor
|
Pushed commit 3874dbf. Was using deprecated symbol name - corrected - sorry about that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #66
Fix #68
Testing performed
https://github.com/nasa/cFS/pull/96/checks
Expected behavior changes
PR #67 - Test cases now compare an expected event string with a string derived from the spec string and arguments that were output by the unit under test.
PR #69 - Replace references to
ccsds.htypes with thecfe_sb.h-provided type.System(s) tested on
Ubuntu:Bionic
Additional context
Part of nasa/cFS#96
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.