Checkpoint in freeze only#2107
Open
sharmeye wants to merge 29 commits into
Open
Conversation
…oints-in-freeze-mode
- Also marked a section for a more detailed revision in a few days
Contributor
|
this MR adds a circular dependency: |
…f not in freeze mode for checkpoint.
|
Coverage is 57.172% — Checkpoint_in_freeze_only into master. No base build found for |
| checkpoint( chk_name_stream.str() ); | ||
| checkpoint( file_name ); | ||
|
|
||
| the_exec->run(); |
Contributor
There was a problem hiding this comment.
i think this unfreezes after checkpoint even when it wasn't an auto-freeze
also: indentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement constraint to allow checkpoints only in freeze mode to preserve homogeneity of data. Also implementing auto-freezing and auto-unfreezing the simulation when a checkpoint is attempted in RUN mode. Credit to @Mrockwell2