Skip to content

Only evaluate 'needs' constraints of an option if that option is actually used. #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nategood merged 1 commit into from
Jul 10, 2019
Merged

Only evaluate 'needs' constraints of an option if that option is actually used. #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Commando/Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,10 +495,11 @@ public function parse()
}
}

// See if our options have what they require
// See if our options have what they require.
// But only do so if the option is actually used
foreach ($this->options as $option) {
$needs = $option->hasNeeds($this->options);
if ($needs !== true) {
if ($needs !== true && array_key_exists($option->getName(), $keyvals)) {
throw new \InvalidArgumentException(
'Option "' . $option->getName() . '" does not have required option(s): ' . implode(', ', $needs)
);
Expand Down