Issue 303: Fixed usage help to display [command] first then [options].#308
Merged
natemcmaster merged 2 commits intonatemcmaster:masterfrom Nov 22, 2019
Merged
Issue 303: Fixed usage help to display [command] first then [options].#308natemcmaster merged 2 commits intonatemcmaster:masterfrom
natemcmaster merged 2 commits intonatemcmaster:masterfrom
Conversation
Should be: Usage: mytool [command] [options] instead of: Usage: mytool [options] [command] Having any options in front of the command verb fails, so the usage help should reflect this.
Owner
|
Thanks for the pull request! I'm happy to have a new contributor. Before I merge, can I trouble you to fix the failing tests? They should be updated to reflect the new behavior. See https://dev.azure.com/natemcmaster/github/_build/results?buildId=604&view=ms.vss-test-web.build-test-results-tab for a list of the test failures. You can check if they will pass locally by executing |
Contributor
Author
|
Happy to help ;) |
Owner
|
Thanks! I'll add you to the release notes |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should be:
Usage: mytool [command] [options]
instead of:
Usage: mytool [options] [command]
Having any options in front of the command verb fails, so the usage help should reflect this.
I'm glad you're about to open a PR. Just a few tips before you click submit:
If you're not sure if something is a "big change", please open an issue first.
Thanks!