Make .Values read-only on CommandArgument/Option#406
Merged
natemcmaster merged 1 commit intorelease/4.0from Nov 7, 2020
Merged
Make .Values read-only on CommandArgument/Option#406natemcmaster merged 1 commit intorelease/4.0from
natemcmaster merged 1 commit intorelease/4.0from
Conversation
Exposing a raw List<string> of values on CommandArgument and CommandOption has made it difficult to cleanly implement features like default values or parsing. This changes the return type of .Values to a read-only list, and adds TryParse for adding new values, and Reset for clearing them.
natemcmaster
added a commit
that referenced
this pull request
Jan 10, 2021
Exposing a raw List<string> of values on CommandArgument and CommandOption has made it difficult to cleanly implement features like default values or parsing. This changes the return type of .Values to a read-only list, and adds TryParse for adding new values, and Reset for clearing them.
This was referenced Aug 1, 2025
This was referenced Sep 2, 2025
This was referenced Oct 1, 2025
This was referenced Nov 1, 2025
This was referenced Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposing a raw List of values on CommandArgument and
CommandOption has made it difficult to cleanly implement features like
default values or parsing. This changes the return type of .Values to a
read-only list, and adds TryParse for adding new values, and Reset for
clearing them.
Upgrading
Before
After