Should set UnderlyingType when use Template#429
Merged
natemcmaster merged 1 commit intonatemcmaster:mainfrom Jan 20, 2021
Merged
Should set UnderlyingType when use Template#429natemcmaster merged 1 commit intonatemcmaster:mainfrom
natemcmaster merged 1 commit intonatemcmaster:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #429 +/- ##
=======================================
Coverage 82.00% 82.00%
=======================================
Files 106 106
Lines 3284 3284
=======================================
Hits 2693 2693
Misses 591 591
Continue to review full report at Codecov.
|
This was referenced Aug 1, 2025
This was referenced Sep 2, 2025
This was referenced Oct 1, 2025
This was referenced Nov 1, 2025
This was referenced Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UnderlyingType was null if use Template. For enum option, If UnderlyingType is null, the help text generator will not add the default values text. This PR fixes the issue.