Allow overridden properties that inherit attributes#556
Allow overridden properties that inherit attributes#556natemcmaster merged 2 commits intonatemcmaster:mainfrom
Conversation
Previously, the property in the base class and the property in the subclass would both be returned, causing us to complain about duplicate arguments/options that are actually the same. Closes natemcmaster#555
|
I think this handles all cases of property overriding while still correctly flagging property hiding/similar-looking private properties, but I'm new to C# so I might have missed an edge case! |
|
@natemcmaster Just a friendly reminder! If you'd like, I could also try adding a regression test for this specific case of attribute inheritance so it doesn't get inadvertently removed again. |
|
Hey, thanks for your patience and the reminder. I had been taking a break from open source. I think this looks like a legitimate bug that needs fixing. Adding some tests to show the bug (and that this change fixes the bug) would be good. I know it's been almost year since you opened this, so sorry for the long delay . |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #556 +/- ##
==========================================
- Coverage 77.79% 77.73% -0.06%
==========================================
Files 104 104
Lines 3333 3342 +9
Branches 728 734 +6
==========================================
+ Hits 2593 2598 +5
- Misses 580 581 +1
- Partials 160 163 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Previously, the property in the base class and the property in the subclass would both be returned, causing us to complain about duplicate arguments/options that are actually the same.
Closes #555