Upgrade dotnet & packages#561
Merged
natemcmaster merged 2 commits intonatemcmaster:mainfrom Dec 27, 2025
Merged
Conversation
Contributor
Chris-Wolfgang
commented
Nov 3, 2025
Chris-Wolfgang
commented
- Upgrade to .Net 8
- Upgraded nuget packages
- Updated some code to work with .Net 8
Adopt nullable reference types and modernize tests Updated method signatures to use nullable reference types (`string?`, `params string?[]`, etc.) for improved nullability handling and alignment with C# 8.0 standards. Refactored floating-point parsing tests to use explicit `double` types and introduced `GetDoublePointSymbolsData` for better test coverage. Improved assertions by replacing outdated patterns (e.g., `Assert.True(false)`) with clearer alternatives like `Assert.Fail`. Enhanced null handling in tests by updating parameters and default values to handle nullable scenarios explicitly. Modernized syntax with updated collection initializers and nullable annotations. Fixed a typo in a method name and ensured consistent use of nullable annotations across the codebase. Added test cases to cover edge cases and improve validation logic. Performed general code cleanup, including removing redundant comments, consolidating test data, and improving formatting for readability and maintainability.
natemcmaster
approved these changes
Dec 27, 2025
Owner
natemcmaster
left a comment
natemcmaster
left a comment
There was a problem hiding this comment.
Thanks for taking care of this!
This was referenced Jan 21, 2026
Closed
Merged
Open
Closed
This was referenced Jan 28, 2026
This was referenced Feb 9, 2026
This was referenced Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.