Add additional functions to pyxx.arrays#17
Merged
Conversation
Added a new function to `pyxx.arrays` to check whether an arbitrary number of sequence-type objects (lists, tuples, and/or strings) have equal length. Added tests for new code
Added new function `pyxx.arrays.np_array_equal()` to check equality (shape and values) of numeric NumPy arrays. Also added tests and documentation for this function
… must use numeric types
…e equal length Added new function that provides the same functionality as `pyxx.arrays.check_len_equal()` but returns only a True/False output and offers a slight performance improvement in certain cases
…xx.arrays.is_array_equal()` function Rewrote array equality function to make it more general, capable of comparing a wider variety of arrays
Revised function logic so that it is capable of handling a wider variety of input types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major Changes and Improvements
pyxx.arraysmodule, and added tests and documentation for all new codepyxx.arrays.check_len_equal()andpyxx.arrays.is_len_equal()compare lengths of input arrays or other objectspyxx.arrays.is_array_equal()checks whether multiple arrays have the same size and content (within a given tolerance for numeric content)Bug Fixes
pyxx/__init__.pyto use string instead of f-stringsetuptoolsrequires specific syntax for reading attributes from a file, and the previous f-string did not function as expected. One possibility (although it would require more debugging to determine) is thatsetuptoolswas attempting to read the f-string statically and obtaining unexpected results.Minor Updates
pyxx.files.FileclassNotes and References
version = attr: pkg.__version__in setup.cfg pypa/setuptools#1724