Skip to content

Brief intoduction of myself and nice poem#15

Open
Lounaf wants to merge 21 commits intonathanielpolley:masterfrom
Lounaf:master
Open

Brief intoduction of myself and nice poem#15
Lounaf wants to merge 21 commits intonathanielpolley:masterfrom
Lounaf:master

Conversation

@Lounaf
Copy link

@Lounaf Lounaf commented Sep 21, 2023

No description provided.

@nathanielpolley
Copy link
Owner

Excellent work, Louna. All of the text outputted correctly when you ran the runfile. My only request would be to have copied the output into the "submit" file instead of the "instructions" file. It is very important that when working on large projects with many moving parts that the correct code goes into the correct file names.

Nonetheless, since the purpose of this assignment was to see if you could connect your GitHub to PyCharm and have PyCharm run your code correctly and submit it back to me, I will award you full points since you demonstrated all of that.

But feel free to do the commit-push-pull request process again with the "submit.txt" file, as it is good practice in learning the interface.

Score: 0.5/0.5

Copy link
Owner

@nathanielpolley nathanielpolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assignment 0 beginner complete

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good. Thank you for making these changes.

Best,

np

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Score: 0.5/0.5

Copy link
Owner

@nathanielpolley nathanielpolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assignment 0 beginner complete
Pending: assignment_0_intermediate

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Score: 0.5/0.5

Copy link
Owner

@nathanielpolley nathanielpolley Sep 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good effort here with coding the main functionality. However, is it possible to do mathematical operations on strings (words)? The equation is correct, but you will need to ask the user for input using the input() function for each of the variables. Then, you will use conditionals to make sure that their input is valid e.g. only positive numerical values. Then you convert all values to ints and run the equation as you have written. Very good start, but there is still work to do before giving a final grade.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very excellent improvements. Just one more thing. Since this is a growth rate calculator, the initial value must always be less than the final value. Can you provide the necessary changes to incorporate this? Then, we can call it a day :)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done.

Score: 1.5/1.5

Copy link
Owner

@nathanielpolley nathanielpolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete: assignment 0 beginner
Pending: assignment 0 intermediate

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very excellent improvements. Just one more thing. Since this is a growth rate calculator, the initial value must always be less than the final value. Can you provide the necessary changes to incorporate this? Then, we can call it a day :)

Copy link
Owner

@nathanielpolley nathanielpolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed: assignment 0 beginner, assignment 0 intermediate

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done.

Score: 1.5/1.5

Copy link
Owner

@nathanielpolley nathanielpolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete: assignment 0 beginner, assignment 0 intermediate
Pending: assignment 0 advanced

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good here. My only recommendation is to fix your GC content calculator as we talked about in class, so that it evaluates to (DNA.count("C")+DNA.count("G"))/len(DNA). As currently, it is only counting how many times the word "GC" appears in the string..for instance "GCGCGC" would return '3' for '3' "GC"s side by side, when it should produce a 1.00 for 100% GC content. Let me know when you have made this fix, and I will regrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants