Skip to content

submission 0 #16

Open
MaureenVrd wants to merge 25 commits intonathanielpolley:masterfrom
MaureenVrd:master
Open

submission 0 #16
MaureenVrd wants to merge 25 commits intonathanielpolley:masterfrom
MaureenVrd:master

Conversation

@MaureenVrd
Copy link

No description provided.

@nathanielpolley
Copy link
Owner

Very good, Maureen. Everything is good to go on your side. One of the great benefits of learning to code on your own is that you can improve existing software to have it do what you want it to do rather than needing to wait until the next version comes out and hope that it has the desired functionality.

Score: 0.5/0.5

Copy link
Owner

@nathanielpolley nathanielpolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete: assignment 0 beginner
Pending: assignment 0 intermediate

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very interesting implementation of the if statement. I hadn't thought of that, but it works, nonetheless. Also, I believe there was something in the directions about GC content calculation. If you could add that for me, that would be great, and I will revisit this for a final mark as soon as you do so.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

Score: 2/2

Copy link
Owner

@nathanielpolley nathanielpolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed: assignment_1_advanced, assignment_1_beginner

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good handling on instantiating and manipulating dictionaries. My only critique would be to set both the length of the initial empty dictionary as the length of the lines2 object so that everything can be the same within your code, and it can work for any length of file being read in. Additionally, for the for the final for loop, you can set it to for i in range(len(lines2)) so it will run for exactly how many lines there are, because, as we see, it outputs at the end a blank entry for space '60', as well as a value for a key of '0'. If you would like an added challenge, see if you can make the output of the "mismatch detected" entries a list of all of the actual mismatches that occur in the line. Overall, very well done.

Score: 2/2

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You accomplished all of the objectives perfectly on this task. If you would like a more shorthand approach (without for loops) to calculate average, you can simply do sum(list)/length(list). Additionally, for minimum and maximum, you can use the min() and max() functions to get the same result. This is especially helpful if you are working with a very large dataset that will take time to iterate through all of the elements.

Score: 0.5/0.5

Copy link
Owner

@nathanielpolley nathanielpolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed: assignment_0_beginner, assignment_0_intermediate, assignment_0_advanced, assignment_1_beginner, assignment_1_intermediate, assignment_1_advanced

Final score: 8/8

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

Score: 2/2

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent handling of all the possible ways that the user could enter something incorrectly.

Score: 1.5/1.5

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything has been accomplished here. My only advice would be to let the user know how to exit the data entry loop. On this, I needed to hit "return" without providing anything in order to terminate the program. Perhaps, requiring the user to type "stop" or "end" would be more explicit so long as it is explained in the prompt.

Score: 1.5/1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants