Conversation
|
Hi Julien. Nice to meet you. I am pleased to see your integration of lambda calculus with the "=>" symbol that you used in the name of your commit. It brings back my days of coding with Scala..the "better" Java. Your ambition is correct as the data is getting bigger, while our understanding of it is inevitably getting smaller. Everything was done correctly, so I will give this full points. Score: 0.5/0.5 |
nathanielpolley
left a comment
nathanielpolley
left a comment
There was a problem hiding this comment.
Thank you for your patience Julien, as this was a very busy week, and I am just now coming around to grade things. Full points on all of the first homeworks.
Completed: assignment 0 beginner, assignment 0 intermediate, assignment 0 advanced
Pending: None
Score: 4/4
There was a problem hiding this comment.
Very excellent work on implementing both the cell rate calculator and the conditionals to vet correct user input.
Score: 1.5/1.5
There was a problem hiding this comment.
Wonderful work here. My only small critique would be to convert seq to seq.upper( ) to handle if the user types in lowercase atcg values. Other than that, very good implementation.
Score: 2/2
There was a problem hiding this comment.
Everything works well for the setup on your end.
Score: 0.5/0.5
nathanielpolley
left a comment
nathanielpolley
left a comment
There was a problem hiding this comment.
Completed: assignment 0 beginner, assignment 0 intermediate, assignment 0 advanced, assignment 1 beginner, assignment 1 intermediate
Pending: None
There was a problem hiding this comment.
Excellent implementation here with all objectives complete. My only recommendation is to take a look at where you print the global output of the stats function without returning a variable to be printed, so then it results in the word "None" being printed to the console. Since you already print the desired output within your function, there is no need to print twice. Likewise, you could have also returned each one of the local variables created in def stats separately as a list and then iterated through the list globally to print each of the outputs.
Score: 0.5/0.5
There was a problem hiding this comment.
Very good work!
Score: 1.5/1.5
2 participants
I had a "pushed 1 commit to origin/master" message and not "3". i do not know if this is a problem.
edit: nevermind, just saw your mail about it.