Skip to content

Jeanine Subramoney#20

Open
JeanineSubramoney wants to merge 22 commits intonathanielpolley:masterfrom
JeanineSubramoney:master
Open

Jeanine Subramoney#20
JeanineSubramoney wants to merge 22 commits intonathanielpolley:masterfrom
JeanineSubramoney:master

Conversation

@JeanineSubramoney
Copy link

Assignment 01

@nathanielpolley
Copy link
Owner

Very excellent work, Jeanine, and a very warm welcome to France. Hopefully, you will find many great places to camp here, so that you can have better Junes in your life to make up for the worst June.

Everything on your GitHub and PyCharm has been set up correctly.

Score: 0.5/0.5

Copy link
Owner

@nathanielpolley nathanielpolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete: assignment 0 beginner
Pending: assignment 0 intermediate

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jeanine. I am very happy to see the advanced structures used in this assignment. There are however, two separate growth rate calculators in your code, one at the beginning from lines 1-23 and another encapsulated into a function restarting from lines 25 to the end once the first executes. In the first, you use .isdigit( ) to ensure that user input is not negative or a decimal. In the second, you convert user input to float first without verifying if it is numerically possible. Let's do two birds with one stone here and combine everything into just one function that uses the .isdigit( ) method you have previously used to vet user input, and once that is complete, you still need to make sure that the initial is always smaller than the final amount, which would be an additional if/else statement nested within the first isdigit if/else statement, as you must ensure that the value can be converted to numeric before converting it and using ">" to verify if one input variable is greater than the other. Keep up the excellent work. I will revisit this for a final grade once these changes have been made.

Copy link
Owner

@nathanielpolley nathanielpolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete: assignment 0 beginner, assignment 0 intermediate, assignment 0 advanced, assignment 1 beginner
Pending: None

Assignment 0 score: 4/4

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very excellent work here. I like your utilization of the all( ) function to sort through the list on the validation step. My only advice to be more organized in your code is to place all import statements of libraries (e.g. "from collections import Counter") at the top of your code so that you can keep track of all of the modules you are importing all in one place.

Score: 2/2

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial setup works on your end.

Score: 0.5/0.5

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one simple correction remaining, to put parentheses around the math.log(int(y)) - math.log(int(x)) statement, as the division at the end of the line is calculated before the remaining operations, leading to a positive growth rate when I entered a smaller final than initial. But nonetheless, everything else worked and you understand the if/else logic behind this, so I will award full points.

Score: 1.5/1.5

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very excellent implementation of the continue statement here to only get the job done on the necessary values.

Score: 0.5/0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants