Conversation
|
Very good work, Hala. You have set up a GitHub account. Forked the class materials to your account. Cloned your forked GitHub repository to PyCharm. Executed the required code on PyCharm. Committed changes and code output on PyCharm to your local repository. Pushed those commits to your remote GitHub repository, and opened a pull request, which I am typing on now to review your files. IBM will be screaming your name, since you made everything run like clockwork. Tik Toc Score: 0.5/0.5 |
|
heheh
Thank you prof.
…________________________________
From: nathanielpolley ***@***.***>
Sent: Monday, September 25, 2023 12:06 AM
To: nathanielpolley/CARe_Python_Class_2023 ***@***.***>
Cc: halashalhoub ***@***.***>; Author ***@***.***>
Subject: Re: [nathanielpolley/CARe_Python_Class_2023] natos phyton (PR #23)
Very good work, Hala. You have set up a GitHub account. Forked the class materials to your account. Cloned your forked GitHub repository to PyCharm. Executed the required code on PyCharm. Committed changes and code output on PyCharm to your local repository. Pushed those commits to your remote GitHub repository, and opened a pull request, which I am typing on now to review your files.
IBM will be screaming your name, since you made everything run like clockwork.
Tik
Toc
Score: 0.5/0.5
—
Reply to this email directly, view it on GitHub<#23 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BCVBDAUMARTMGHGKOBFNYBDX4COEBANCNFSM6AAAAAA5CDREQQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
nathanielpolley
left a comment
nathanielpolley
left a comment
There was a problem hiding this comment.
Complete: assignment 0 beginner
Pending: assignment 0 intermediate
There was a problem hiding this comment.
Very excellent start. The only thing remaining is to remove the parentheses when the user inputs the variables, as you have accidentally created a tuple data type. I will revisit this for a final mark once this change has been made.
nathanielpolley
left a comment
nathanielpolley
left a comment
There was a problem hiding this comment.
Completed: assignment 0 beginner, assignment 0 intermediate
There was a problem hiding this comment.
Immaculate performance. A++
Score: 1.5/1.5
nathanielpolley
left a comment
nathanielpolley
left a comment
There was a problem hiding this comment.
Complete: assignment 0 beginner, assignment 0 intermediate
Pending: assignment 0 advanced
There was a problem hiding this comment.
I appreciate the commitment to your commit here. However, there are just a few more things that need to be done in order for this to reach perfection. First, the DNASeq.count( ) arguments need to be placed within the if statement after user input has been confirmed. Once that happens, you print our the necessary attributes. Secondly, for GC content, when you do .count("GC"), what that does is that it counts how many times the string "GC" appears in your DNA sequence..not the individual Gs and Cs themselves. So what you will want to do is take the individual count of the Cytosine_count and add that to the Guanine_count, and take the sum of all of that and divide it by the total DNAlength variable, multiplied by 100 to get the GC content. Once all of that has been implemented, I can revisit this to assess it for a final grade.
There was a problem hiding this comment.
Everything is complete except the if statement needs to be reworked, as I can input any string and the code will still run. Try adapting your if statement to the first answer on this forum:
https://stackoverflow.com/questions/26703664/check-if-a-string-contains-only-given-characters
Your if case will then check for the invalid condition to which you will print "the DNA sequence is invalid".
You will then invert all of the operations you currently have in your if statement into your else statement in the case that everything is valid in the user input.
There was a problem hiding this comment.
Excellent fix. Full points.
Even though we cannot let errors pass silently..always believe in yourself.
Score: 2/2
nathanielpolley
left a comment
nathanielpolley
left a comment
There was a problem hiding this comment.
Complete: assignment 0 beginner, assignment 0 intermediate
Pending: assignment 0 advanced
There was a problem hiding this comment.
Everything is complete except the if statement needs to be reworked, as I can input any string and the code will still run. Try adapting your if statement to the first answer on this forum:
https://stackoverflow.com/questions/26703664/check-if-a-string-contains-only-given-characters
Your if case will then check for the invalid condition to which you will print "the DNA sequence is invalid".
You will then invert all of the operations you currently have in your if statement into your else statement in the case that everything is valid in the user input.
nathanielpolley
left a comment
nathanielpolley
left a comment
There was a problem hiding this comment.
Complete: assignment 0 beginner, assignment 0 intermediate, assignment 0 advanced
Pending: None
Score: 4/4
There was a problem hiding this comment.
Excellent fix. Full points.
Even though we cannot let errors pass silently..always believe in yourself.
Score: 2/2
2 participants
natos phyton