Skip to content

assignment Ilias Simon#24

Open
Ili02 wants to merge 10 commits intonathanielpolley:masterfrom
Ili02:master
Open

assignment Ilias Simon#24
Ili02 wants to merge 10 commits intonathanielpolley:masterfrom
Ili02:master

Conversation

@Ili02
Copy link

@Ili02 Ili02 commented Sep 27, 2023

No description provided.

Copy link
Owner

@nathanielpolley nathanielpolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very good start. Please review my comments for each piece of your work. I am allowing students to fix their code as many times as they need before receiving a final mark.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort on this part. I do, however, have some recommendations. There is a simpler way to determine if a variable that the user inputs is an int variable type (think first lesson on the first day), rather than iterating through a list of ALL possible integer values. Additionally, once the user's integer input has been validated, there are two other logical conditions that must be satisfied, which we will talk about next class, but feel free to implement in the meantime.

I will provide a final grade once this code is both 1) simplified and 2) takes into account the remaining numerical conditions.

Best of luck, and feel free to ask any questions using this platform.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this surprinsingly quick correction,
I've made the adjustement you've suggested, but i'm really not familiar with this software, are you able to see it ?
Once again, thank you and have a good day.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done with testing if the input is numerical in a more straightforward manner. Now the only thing left to do is ensure that the numerical input is both positive (as negative log will result in an error) and that the end number of cells is always greater than the beginning, as this is a measurement of exponential growth and not decay.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellently done.

Score: 1.5/1.5

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be sure that the beginner_runfile was able to be run. The "import this" line should produce a poem before the answer to your prompts is output. This is for me to ensure that your PyCharm is able to interpret Python code as it should. Please copy and paste the entire output from the runfile appearing on the console into the submit.txt file and resubmit. Thank you in advance.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on accomplishing the objectives. There is, however, a more efficient way to "count" the number of occurrences in a string rather than having to iterate through each character and increment counter variables. Please refer to the link below, and you should be able to condense around 20 lines of this into only 4, a good practice with code "refactoring".

https://stackoverflow.com/questions/1155617/count-the-number-of-occurrences-of-a-character-in-a-string

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellently done in incorporating "simple is better than complex", "flat is better than nested" into your code.

Score: 2/2

@Ili02 Ili02 closed this Sep 27, 2023
@Ili02 Ili02 reopened this Sep 27, 2023
@Ili02 Ili02 changed the title assignment_0 IS assignment Ilias Simon Oct 12, 2023
Copy link
Owner

@nathanielpolley nathanielpolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete: assignment 0 beginner, assignment 0 intermediate, assignment 0 advanced, assignment 1 intermediate
Pending: assignment 1 beginner, assignment 1 advanced

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellently done.

Score: 1.5/1.5

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing to do here. You must print out the days in which the microbial count exceeds 200 (easy enough since you did all the rest). I will revisit once that is done.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful job here. All of the tasks were completed, and you demonstrated good comprehension of dictionaries in Python.

Score: 1.5/1.5

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this, you will need to load the lines of each file into a dictionary with the reference numbers as keys, iterate through the dictionaries, and determine if the entry is identical or not, and if not provide a list of the differences in the strings. You have a good start here with reading in the files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants