Skip to content

Ex1_Ex2_M2_S1_Py_Tricaud_Maxence#30

Open
mt93git wants to merge 5 commits intonathanielpolley:masterfrom
mt93git:master
Open

Ex1_Ex2_M2_S1_Py_Tricaud_Maxence#30
mt93git wants to merge 5 commits intonathanielpolley:masterfrom
mt93git:master

Conversation

@mt93git
Copy link

@mt93git mt93git commented Oct 9, 2023

No description provided.

Copy link
Owner

@nathanielpolley nathanielpolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete: assignment 0 beginner, assignment 0 intermediate, assignment 0 advanced
Pending: None

Final score: 4/4

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellently done here. Everything works on your end with both the Git interface and PyCharm. I, too, was once bitten by a Norwegian troll and transformed with the Equinox..I was hoping for Thor, but this is how I turned out.

Score: 0.5/0.5

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is like the Duke Ellington jazz interpretation of this assignment..had me laughing in my chair and gave me hope for humanity. Brilliant use of function encapsulation and try/except statements. In fact, I believe I will review functions and for loops at the beginning of class tomorrow. Can I use yours as an example?

Best,
np

Score: 1.5/1.5

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect execution that does more using less. I also appreciate the decimal rounding within the f-string output. You sure you don't want to do this for a living?

Score: 2/2

Copy link
Owner

@nathanielpolley nathanielpolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed: assignment 0 beginner, assignment 0 intermediate, assignment 0 advanced, assignment 1 beginner, assignment 1 intermediate, assignment 1 advanced
Pending: None

Total score: 8/8

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can appreciate the implementation of this where it prints out the updated dictionary per each cycle of the loop. Very good work!

Score: 1.5/1.5

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good organization with function definitions and function calls. You will be more than ready for the object-oriented assignments I will have prepared soon.

Score: 0.5/0.5

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are the second student so far to have succeeded in this impossible endeavor..You have also broken the system with your knowledge of regular expressions! Very eloquent system using the fuzzywuzzy package in order to establish a threshold of similarity. Truly above and beyond with this one.

Score: 2/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants