Skip to content

emma#32

Open
Emmahuard wants to merge 11 commits intonathanielpolley:masterfrom
Emmahuard:master
Open

emma#32
Emmahuard wants to merge 11 commits intonathanielpolley:masterfrom
Emmahuard:master

Conversation

@Emmahuard
Copy link

No description provided.

Copy link
Owner

@nathanielpolley nathanielpolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed: assignment 0 beginner, assignment 0 advanced, assignment 1 beginner, assignment 1 intermediate
Pending: assignment 1 intermediate

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good here, Python and PyCharm are installed to your computer, and you were able to connect it to your GitHub account.

Score: 0.5/0.5

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on this on having the correct functionality. The one task that remains is to ensure that the user can only enter valid input. For instance, when I write "abc" into your program, it returns a ValueError, as an alphabetical string cannot be converted into a float. We also cannot have negative cell or time values. This can be handled using the .isdigit( ) string method that returns a true or a false if the string only contains "0-9" values. It also takes into account negatives, as an entry with "-" will return false. This will be your outer if/else statement. You also want to ensure that your final amount is greater than your initial amount, as this is a growth rate calculator. Your string literals containing these values need to be converted into floats after they have been validated by the outer if/else statement, and then you will write an inner if/else statement to check if final > initial. I will revisit this for a final grade once these changes have been implemented. Thank you for your patience.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very excellent work here handling your data using lists and encapsulated with functions. Ideally, you will want to put "break" instead of returning an empty value with "return( )", as this results in a syntax error since you are referencing a list indexes in your print statement. If there is nothing there, then there is no index to reference, and you get a corresponding IndexError, so it would just be better to "break" out of the if statement entirely. As this is such a small point, and you did everything else correctly, I will award the full points regardless.

Score: 2/2

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job here with all of the topics successfully implemented.

Score: 0.5/0.5

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice demonstrated knowledge of dictionary manipulation here. I also like the condensed for loop list you did for species_greater_than_15, as well as the while True loop that insures that input is numeric and correct.

Score: 1.5/1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants