Conversation
submit.txt added output from console
nathanielpolley
left a comment
nathanielpolley
left a comment
There was a problem hiding this comment.
Beginner objectives satisfied.
Beginner score: 0.5/0.5
Intermediate score: pending/1
Advances score: pending/2
There was a problem hiding this comment.
Perfect work here, Jose Edgar. You successfully connected your PyCharm to your GitHub with a push and pull request, and Python3 works on your machine since "import this" was able to output the poem.
Ah, a bioinformatician with R skills eyeing an M.D. Ph.D. and a foot in both wet and dry labs? Sounds like you're aiming to be the Swiss Army knife of the medical world! Just remember, when you're juggling test tubes and code, don't mix up your pipettes and your pixels. We wouldn't want you debugging bacteria or sequencing syntax errors. And hey, with all that lab-hopping, you might just discover a new state of matter: non-Newtonian fluid research!
Score: 0.5/0.5
nathanielpolley
left a comment
nathanielpolley
left a comment
There was a problem hiding this comment.
Beginner objectives satisfied.
Intermediate objectives pending.
Advanced objectives satisfied.
Total score: pending/3
There was a problem hiding this comment.
Very excellent work here. I am duly impressed by your use of regular expressions to make sure that the input is only ATCG..easy to learn but hard to master.
All objectives satisfied, however, if you would like this code to go above and beyond, see if you can make it loop for each time there is incorrect input, and only terminate once the input condition is met.
Full points awarded.
Score 2/2
There was a problem hiding this comment.
And a case for ambiguous purines/pyrimidines..I would give bonus points if I had the authority to. Perhaps in another life.
added escape for R and Y for fasta files Corrected outputs
corrected description and arguments
corrected description and arguments
nathanielpolley
left a comment
nathanielpolley
left a comment
There was a problem hiding this comment.
Beginner objectives satisfied.
Intermediate objectives pending.
Advanced objectives satisfied.
Total score: pending/3
There was a problem hiding this comment.
And a case for ambiguous purines/pyrimidines..I would give bonus points if I had the authority to. Perhaps in another life.
There was a problem hiding this comment.
Very nice start here. The growth rate is calculated accurately. And you verify that the user's input is not "None". However, there are a few more steps involved with input validation. First, the final cell count must always be a larger value than the initial cell count, as this is a growth calculator and not a death calculator. Secondly, there cannot be negative values for either cell counts or time. Third, the input for cell counts must be a while number int, as there cannot be fractions of cells. This can be performed using the ".isdigit()" method on the string input. This will also assure that the value is numeric. Be sure to do this check before doing the int() function on the input to change the string value to int. As a bonus, try to see if you can truncate the final growth rate to only four decimal places, as if you had to fill in a spreadsheet with millions of values, having a twenty digit output may flood the memory with insignificant digits.
So, all in all, just a few more conditionals to add, and you should be golden.
Score: pending/1
2 participants
runfile.py added my description
submit.txt added output from console