Skip to content

Polish java module test codes #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acktsap merged 1 commit into from
Feb 6, 2025
Merged

Polish java module test codes #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 14 additions & 16 deletions ...ercorp/spring/batch/plus/item/adapter/ItemStreamReaderProcessorWriterIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@

package com.navercorp.spring.batch.plus.item.adapter;

import static com.navercorp.spring.batch.plus.item.adapter.AdapterFactory.itemProcessor;
import static com.navercorp.spring.batch.plus.item.adapter.AdapterFactory.itemStreamReader;
import static com.navercorp.spring.batch.plus.item.adapter.AdapterFactory.itemStreamWriter;
import static org.assertj.core.api.Assertions.assertThat;

import java.util.UUID;
Expand Down Expand Up @@ -56,7 +53,8 @@

import reactor.core.publisher.Flux;

@SuppressWarnings("unchecked")
// note: it's deprecated. Do not change it.
@SuppressWarnings({"unchecked", "deprecation"})
class ItemStreamReaderProcessorWriterIntegrationTest {

private static final int TEST_REPEAT_COUNT = 5;
Expand Down Expand Up @@ -112,9 +110,9 @@ void testReaderProcessorWriter() throws Exception {
.start(
new StepBuilder("testStep", jobRepository)
.<Integer, Integer>chunk(chunkCount, new ResourcelessTransactionManager())
.reader(itemStreamReader(testTasklet))
.processor(itemProcessor(testTasklet))
.writer(itemStreamWriter(testTasklet))
.reader(AdapterFactory.itemStreamReader(testTasklet))
.processor(AdapterFactory.itemProcessor(testTasklet))
.writer(AdapterFactory.itemStreamWriter(testTasklet))
.build()
)
.build();
Expand Down Expand Up @@ -157,9 +155,9 @@ void testReaderProcessorWriterWithSameTaskletShouldKeepContext() throws Exceptio
.start(
new StepBuilder("testStep", jobRepository)
.<Integer, Integer>chunk(chunkCount, new ResourcelessTransactionManager())
.reader(itemStreamReader(testTasklet))
.processor(itemProcessor(testTasklet))
.writer(itemStreamWriter(testTasklet))
.reader(AdapterFactory.itemStreamReader(testTasklet))
.processor(AdapterFactory.itemProcessor(testTasklet))
.writer(AdapterFactory.itemStreamWriter(testTasklet))
.build()
)
.build();
Expand Down Expand Up @@ -198,9 +196,9 @@ void testStepScopeReaderProcessorWriter() throws Exception {
.start(
new StepBuilder("testStep", jobRepository)
.<Integer, Integer>chunk(chunkCount, new ResourcelessTransactionManager())
.reader(itemStreamReader(testTasklet))
.processor(itemProcessor(testTasklet))
.writer(itemStreamWriter(testTasklet))
.reader(AdapterFactory.itemStreamReader(testTasklet))
.processor(AdapterFactory.itemProcessor(testTasklet))
.writer(AdapterFactory.itemStreamWriter(testTasklet))
.build()
)
.build();
Expand Down Expand Up @@ -243,9 +241,9 @@ void testStepScopeReaderProcessorWriterWithSameTaskletShouldNotKeepCountContext(
.start(
new StepBuilder("testStep", jobRepository)
.<Integer, Integer>chunk(chunkCount, new ResourcelessTransactionManager())
.reader(itemStreamReader(testTasklet))
.processor(itemProcessor(testTasklet))
.writer(itemStreamWriter(testTasklet))
.reader(AdapterFactory.itemStreamReader(testTasklet))
.processor(AdapterFactory.itemProcessor(testTasklet))
.writer(AdapterFactory.itemStreamWriter(testTasklet))
.build()
)
.build();
Expand Down
21 changes: 10 additions & 11 deletions ...a/com/navercorp/spring/batch/plus/item/adapter/ItemStreamReaderWriterIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@

package com.navercorp.spring.batch.plus.item.adapter;

import static com.navercorp.spring.batch.plus.item.adapter.AdapterFactory.itemStreamReader;
import static com.navercorp.spring.batch.plus.item.adapter.AdapterFactory.itemStreamWriter;
import static org.assertj.core.api.Assertions.assertThat;

import java.util.UUID;
Expand Down Expand Up @@ -55,7 +53,8 @@

import reactor.core.publisher.Flux;

@SuppressWarnings("unchecked")
// note: it's deprecated. Do not change it.
@SuppressWarnings({"unchecked", "deprecation"})
class ItemStreamReaderWriterIntegrationTest {

private static final int TEST_REPEAT_COUNT = 5;
Expand Down Expand Up @@ -107,8 +106,8 @@ void testReaderWriter() throws Exception {
.start(
new StepBuilder("testStep", jobRepository)
.<Integer, Integer>chunk(chunkCount, new ResourcelessTransactionManager())
.reader(itemStreamReader(testTasklet))
.writer(itemStreamWriter(testTasklet))
.reader(AdapterFactory.itemStreamReader(testTasklet))
.writer(AdapterFactory.itemStreamWriter(testTasklet))
.build()
)
.build();
Expand Down Expand Up @@ -151,8 +150,8 @@ void testReaderWriterWithSameTaskletShouldKeepCountContext() throws Exception {
.start(
new StepBuilder("testStep", jobRepository)
.<Integer, Integer>chunk(chunkCount, new ResourcelessTransactionManager())
.reader(itemStreamReader(testTasklet))
.writer(itemStreamWriter(testTasklet))
.reader(AdapterFactory.itemStreamReader(testTasklet))
.writer(AdapterFactory.itemStreamWriter(testTasklet))
.build()
)
.build();
Expand Down Expand Up @@ -190,8 +189,8 @@ void testStepScopeReaderWriter() throws Exception {
.start(
new StepBuilder("testStep", jobRepository)
.<Integer, Integer>chunk(chunkCount, new ResourcelessTransactionManager())
.reader(itemStreamReader(testTasklet))
.writer(itemStreamWriter(testTasklet))
.reader(AdapterFactory.itemStreamReader(testTasklet))
.writer(AdapterFactory.itemStreamWriter(testTasklet))
.build()
)
.build();
Expand Down Expand Up @@ -234,8 +233,8 @@ void testStepScopeReaderWriterWithSameTaskletShouldNotKeepCountContext() throws
.start(
new StepBuilder("testStep", jobRepository)
.<Integer, Integer>chunk(chunkCount, new ResourcelessTransactionManager())
.reader(itemStreamReader(testTasklet))
.writer(itemStreamWriter(testTasklet))
.reader(AdapterFactory.itemStreamReader(testTasklet))
.writer(AdapterFactory.itemStreamWriter(testTasklet))
.build()
)
.build();
Expand Down
Loading