[FIX] Applying PCA in dss_line() #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulroujansky
force-pushed
the
fix_dss_line
branch
from
2018151 to
fb5efe2
Compare
paulroujansky
force-pushed
the
fix_dss_line
branch
from
fb5efe2 to
2bbb002
Compare
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
==========================================
+ Coverage 68.35% 68.62% +0.27%
==========================================
Files 14 14
Lines 1839 1839
==========================================
+ Hits 1257 1262 +5
+ Misses 582 577 -5
Continue to review full report at Codecov.
|
nbara
approved these changes
Oct 20, 2020
Owner
nbara
left a comment
nbara
left a comment
There was a problem hiding this comment.
Nice catch. Thanks @paulroujansky
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wrong operation when applying PCA in
dss_line()(probably a typo).Enhanced test.