Fix #69: Auto-accept GitHub SSH host key on fresh installations#71
Closed
Fix #69: Auto-accept GitHub SSH host key on fresh installations#71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensureGitHubHostKeyfunction that automatically whitelists GitHub's SSH host key before git clone operationsssh-keyscan github.comto fetch and add the host key to~/.ssh/known_hostsProblem
When flock is set up on a new machine for the first time, the first git clone when adding a new repository fails because the SSH host keys are not whitelisted. This requires manual intervention to accept the host key.
Solution
Before performing any SSH-based git clone (in
cloneOrGetRepo), the code now ensures GitHub's SSH host key is in the known_hosts file. This prevents "Host key verification failed" errors on fresh installations.Testing
Fixes #69