fix: send heartbeat on new orchestrator sessions#73
Closed
RaghavSood wants to merge 1 commit intomainfrom
Closed
Conversation
Remove the early return in SendHeartbeat that was incorrectly skipping the heartbeat message when a new orchestrator session was created. This bug caused new tasks to never be picked up because the orchestrator never received the heartbeat instructions to check for new issues. This change also adds retry logic for failed heartbeats and only increments the heartbeat count for non-bootstrap heartbeats to avoid premature session rotation. Fixes #72
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SendHeartbeatthat was incorrectly skipping the heartbeat message when a new orchestrator session was createdChanges
The fix modifies
internal/agent/orchestrator.go:Removed early return: Previously, when
justCreatedwas true (meaning a new session was bootstrapped), the code would return early without sending a heartbeat. This is problematic because the orchestrator needs to receive heartbeat instructions to write decision files (new_tasks.json, etc.).Always send heartbeat: Now the heartbeat message is always sent, regardless of whether the session was just created.
Fixed heartbeat count increment: The heartbeat count is now only incremented for non-bootstrap heartbeats to maintain accurate metrics.
Fixes #72