Merged
Conversation
added 15 commits
March 17, 2015 13:14
Contributor
|
Looks great! Maybe I'm missing something, though, but I don't see a test. I see stuff in test.robot, but I don't see where the listener is being tested. |
Contributor
|
Cool, what about tests? Is that what the new files at the top level are supposed to be? |
Author
|
No those files shouldn't have been committed. I guess I should write tests ideally, but writing them for this is probably not worth it. It would be hard to mock up, and maybe not worth it. You can take a stab at it, but I really should be moving on...I'll remove those files. |
Author
|
Can I merge? |
Contributor
|
👍 |
Contributor
|
ok On Tue, Mar 24, 2015 at 12:46 PM, frishberg notifications@github.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made base page library a listener itself so that we can tag sauce jobs with test names and status.