Release/4.9.0 #57
Release/4.9.0 #57
Conversation
* Upgraded kubernetes java client library to version 24.0.0 and added debugging statement for failed condition * Switched to legacy library version since we still use Java 8. * Replace openjdk-8 image * Updated conditionals for determining workflow step execution - if a dataset is optional and there is an issue with it, we should not fail the step * Fixed workflow template bug where if a workflow step input was connected to another steps output, then no other unconnected output would be in the template for that step since add was now false and never reset to true * Cleaned up debug statements so they can be used later by adjusting the log level * Fixes #52, Fixes #55, Fixes #56 and updated CHANGELOG
ywkim312
left a comment
ywkim312
left a comment
There was a problem hiding this comment.
My only concern is the template/deployment.yaml and values.yaml. However, if it doesn't need any changes, that should be okay. Also, if you tested this in dev cluster, it means that those should be good to go. Approve
I did and everything seemed to be working ok. I assume you mean things like the hard coded ncsa/checks:1.0.1? @robkooper did most/all of the chart so maybe after this release we can discuss if there are improvements/generalizations of things we might want to do. |
if you tested and it worked then it should be fine. Sometimes, when there is version up, there are somethings that doesn't match when deployed by the change of the variable name or others, but it doesn't happen in every time. So, if it tested and worked, then it should be good to go. |
Release 4.9.0. Addresses the following: