Skip to content

Conversation

@nikhil-amin
Copy link
Contributor

@nikhil-amin nikhil-amin commented Oct 4, 2021

Description

  • Added email validation to the input. Input will now be first validated and username/domain shall be displayed only for valid email IDs. "Invalid Email" message will be displayed otherwise.
  • Typo of input "Remander" corrected to "Remainder"
  • UI of smart calculater fixed

Fixes #(issue_no)

  • Issue_no: <insert your issue no here>
  • Not applicable

Type of change

Choosing one or more options from the following as per the nature of your Pull request.

  • New project insert
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation Update

Checklist:

Please tick all the boxes that are fulfilled by your Pull Request.

  • I have named my files and folder, according to this project's guidelines.
  • My code follows the style guidelines of this project.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
  • My changes do not produce any warnings.

@nikhil-amin nikhil-amin changed the title [ADD] Email Validation [ADD] Email Validation + UI Corrected + Typo fix Oct 4, 2021
@ndleah ndleah merged commit cd70a6a into ndleah:main Oct 6, 2021
@nikhil-amin
Copy link
Contributor Author

Hey, thanks for the merge. Can you please add hacktoberfest-accepted label on this PR?

magar51 added a commit to magar51/python-mini-project that referenced this pull request Mar 5, 2024
New feature for error and logs handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants