Skip to content

Add optional mapId config for GeoJsonFolder#143

Merged
josephbirkner merged 1 commit intofix/140-withAttrLayers-defaultfrom
fix/142-geojson-custom-mapId
Feb 3, 2026
Merged

Add optional mapId config for GeoJsonFolder#143
josephbirkner merged 1 commit intofix/140-withAttrLayers-defaultfrom
fix/142-geojson-custom-mapId

Conversation

@MisterGC
Copy link
Contributor

Add optional mapId property to GeoJsonFolder config, allowing users to set a custom map identifier instead of relying on automatic derivation from the folder path.

  • Add mapId to the JSON schema for GeoJsonFolder
  • Pass mapId to GeoJsonSource constructor (falls back to path-derived ID if not provided)

Closes #142

@sonarqubecloud
Copy link

@github-actions
Copy link

Package Line Rate Branch Rate Health
libs.geojsonsource.include.geojsonsource 100% 50% βœ”
libs.geojsonsource.src 76% 43% βž–
libs.gridsource.include.gridsource 0% 0% ❌
libs.gridsource.src 0% 0% ❌
libs.http-datasource.src 57% 30% βž–
libs.http-service.include.mapget.http-service 100% 100% βœ”
libs.http-service.src 58% 20% βž–
libs.logging.include.mapget 8% 4% ❌
libs.model.include.mapget.model 54% 32% βž–
libs.model.src 62% 33% βž–
libs.service.include.mapget.service 40% 0% ❌
libs.service.src 78% 41% βž–
Summary 57% (4175 / 7343) 28% (4164 / 14628) βž–

Minimum allowed line rate is 50%

Copy link
Contributor

@josephbirkner josephbirkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘ πŸ’―

@josephbirkner josephbirkner merged commit edf7020 into fix/140-withAttrLayers-default Feb 3, 2026
19 of 20 checks passed
@josephbirkner josephbirkner deleted the fix/142-geojson-custom-mapId branch February 3, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants