Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ Codex CLI-first multi-account OAuth manager for the official `@openai/codex` CLI
### Option A: Standard install

```bash
npm i -g @openai/codex
npm i -g codex-multi-auth
```
Comment on lines 50 to 54
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no windows filesystem / token safety context — org policy violation

per our merge policy, every change to oc-chatgpt-multi-auth must explain how it defends against windows filesystem concurrency bugs and token leakage. this pr removes the separate @openai/codex install step, which directly affects how the codex binary lands on disk. on windows, having two npm globals race to write the same binary path is exactly the kind of concurrency footgun we track — the eexist fix is correct, but the pr description and docs should explicitly state:

  • bundling removes the binary race on windows (no concurrent npm i workers writing the same path)
  • no token files are created or moved by this install change
  • no regression test covers the eexist scenario under windows file locking

please add a sentence in the pr body (or a code comment in the relevant install script) covering these points before merge.

Rule Used: What: Every code change must explain how it defend... (source)

Prompt To Fix With AI
This is a comment left during a code review.
Path: README.md
Line: 50-54

Comment:
**no windows filesystem / token safety context — org policy violation**

per our merge policy, every change to oc-chatgpt-multi-auth must explain how it defends against windows filesystem concurrency bugs and token leakage. this pr removes the separate `@openai/codex` install step, which directly affects how the `codex` binary lands on disk. on windows, having two npm globals race to write the same binary path is exactly the kind of concurrency footgun we track — the eexist fix is correct, but the pr description and docs should explicitly state:

- bundling removes the binary race on windows (no concurrent `npm i` workers writing the same path)
- no token files are created or moved by this install change
- no regression test covers the eexist scenario under windows file locking

please add a sentence in the pr body (or a code comment in the relevant install script) covering these points before merge.

**Rule Used:** What: Every code change must explain how it defend... ([source](https://app.greptile.com/review/custom-context?memory=637a42e6-7a78-40d6-9ef8-6a45e02e73b6))

How can I resolve this? If you propose a fix, please make it concise.


Expand All @@ -75,18 +74,16 @@ codex auth status

### Step-by-step

1. Install global packages:
- `npm i -g @openai/codex`
1. Install global package:
- `npm i -g codex-multi-auth`
2. Run first login flow with `codex auth login`
3. Validate state with `codex auth list` and `codex auth check`
3. Validate state with `codex auth status` and `codex auth check`
4. Confirm routing with `codex auth forecast --live`
Comment on lines +77 to 81
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

add a small docs regression guard and a windows stale-shim note.

please add a regression test that validates README command snippets against the CLI usage surface (for example against printUsage output in lib/codex-manager.ts:1-30). also add a windows edge-case note for stale global shims/path collisions (e.g., where codex and cleanup guidance) near this install flow. this avoids recurrence of install-command drift.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@README.md` around lines 77 - 81, Add a docs regression test that parses the
README command snippets and asserts they match the CLI usage output from
printUsage in lib/codex-manager.ts (call printUsage/programmatic usage generator
and compare expected tokens like "codex auth login", "codex auth status", "codex
auth check", "codex auth forecast --live"); place the test under the docs/tests
suite and fail CI when mismatches occur. Also update the README install flow
around the global install steps to include a short Windows stale-shim note
explaining how to run where codex, remove stale global shims from PATH, and
re-run npm i -g to avoid path collisions. Ensure the test references
printUsage() explicitly and the README update points to the same command strings
validated by the test.


### Verification

```bash
codex auth status
codex auth list
codex auth check
```

Expand All @@ -98,7 +95,7 @@ codex auth check

```bash
codex auth login
codex auth list
codex auth status
codex auth check
codex auth forecast --live
```
Expand Down