Use Gradle's build in warning mode failure #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielThomas
force-pushed
the
warning-mode
branch
from
ad96986 to
ede2472
Compare
chali
reviewed
Jan 22, 2020
Member
chali
left a comment
chali
left a comment
There was a problem hiding this comment.
Do you think you could add an easy way to override value? A bunch of our tests is using system property to ignore warnings or passing different level through command-line arguments. Having an ability to override it per test would be awesome.
DanielThomas
force-pushed
the
warning-mode
branch
from
ede2472 to
d9030e9
Compare
DanielThomas
changed the title
Contributor
Author
|
Looks like this'll break cross-version testing. Let me work on this some more. |
DanielThomas
force-pushed
the
warning-mode
branch
from
d9030e9 to
951560f
Compare
DanielThomas
changed the title
rpalcolea
previously approved these changes
Jan 31, 2020
DanielThomas
force-pushed
the
warning-mode
branch
from
951560f to
128974f
Compare
OdysseusLives
approved these changes
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning mode has had a
failoption since Gradle 5.6. This switches to the property, allows the warning mode to be configured and removes our implementation that's always liable to break with new releases.