Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 20, 2025

Added German localization for all 110 language strings in the LB Planner plugin.

Changes

  • Created lbplanner/lang/de/local_lbplanner.php with German translations
  • All strings translated including general UI, capabilities, settings, error messages, and invite states
  • Preserved Moodle variable placeholders ({$a}, {$a->name}, etc.) for dynamic content

The German translations file follows Moodle language file conventions with proper license headers and structure.

Review Feedback Addressed

  • Line 38: Changed "Reservierungsbereich" to "Reservierungszeitraum"
  • Line 39: Improved wording for futuresight description
  • Line 40: Changed "Veralteter Bereich der Kurse" to "Sichtbarkeitsdauer nach Kursende"
  • Line 41: Fixed "in EduPlanner" to "im EduPlanner"
  • Line 43: Improved wording for Sentry DSN description
  • Improved all other German translations with shorter, more natural phrasing
  • Switched to informal "du" form for user-facing messages
  • Removed Italian translations (to be implemented later by @MasterMarcoHD)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: mcquenji <60017181+mcquenji@users.noreply.github.com>
Copilot AI changed the title [WIP] Add German and Italian translations for strings Add German and Italian translations for LB Planner Nov 20, 2025
Copilot AI requested a review from mcquenji November 20, 2025 20:42
@mcquenji mcquenji requested review from MasterMarcoHD and RiedleroD and removed request for mcquenji November 20, 2025 20:42
@mcquenji mcquenji marked this pull request as ready for review November 20, 2025 20:42
@mcquenji mcquenji changed the title Add German and Italian translations for LB Planner chore: Add German and Italian translations for LB Planner Nov 20, 2025
@mcquenji mcquenji changed the title chore: Add German and Italian translations for LB Planner chore: Add German and Italian translations Nov 20, 2025
Copy link
Contributor

@RiedleroD RiedleroD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not gonna bother going through all of them rn, I wanna stop having to look at translation strings…

these don't seem very good. I guess it's still marginally less work to do it like this though…

$string['lb_planner:teacher'] = 'LB Planner Lehrer';
$string['lb_planner:slotmaster'] = 'LB Planner Slotmaster';
// Settings
$string['sett_futuresight_title'] = 'Reservierungsbereich der Studenten';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

range != bereich

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zeitraum?

Suggested change
$string['sett_futuresight_title'] = 'Reservierungsbereich der Studenten';
$string['sett_futuresight_title'] = 'Reservierungszeitraum der Studenten';

$string['lb_planner:slotmaster'] = 'LB Planner Slotmaster';
// Settings
$string['sett_futuresight_title'] = 'Reservierungsbereich der Studenten';
$string['sett_futuresight_desc'] = 'Maximale Anzahl der Tage im Voraus, an denen Studenten Slots reservieren können. (0 = nur am selben Tag)';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

komisch formuliert. muss überarbeitet werden.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$string['sett_futuresight_desc'] = 'Maximale Anzahl der Tage im Voraus, an denen Studenten Slots reservieren können. (0 = nur am selben Tag)';
$string['sett_futuresight_desc'] = 'Wie viele Tage im Voraus Studierende Termine/Slots buchen dürfen. (0 = nur am selben Tag)';

// Settings
$string['sett_futuresight_title'] = 'Reservierungsbereich der Studenten';
$string['sett_futuresight_desc'] = 'Maximale Anzahl der Tage im Voraus, an denen Studenten Slots reservieren können. (0 = nur am selben Tag)';
$string['sett_outdaterange_title'] = 'Veralteter Bereich der Kurse';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

range ist immer noch nicht bereich

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$string['sett_outdaterange_title'] = 'Veralteter Bereich der Kurse';
$string['sett_outdaterange_title'] = 'Sichtbarkeitsdauer nach Kursende';

$string['sett_futuresight_title'] = 'Reservierungsbereich der Studenten';
$string['sett_futuresight_desc'] = 'Maximale Anzahl der Tage im Voraus, an denen Studenten Slots reservieren können. (0 = nur am selben Tag)';
$string['sett_outdaterange_title'] = 'Veralteter Bereich der Kurse';
$string['sett_outdaterange_desc'] = 'Die maximale Dauer, die ein Kurs nach seinem Ende in EduPlanner sichtbar bleibt.';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in → im

$string['sett_outdaterange_title'] = 'Veralteter Bereich der Kurse';
$string['sett_outdaterange_desc'] = 'Die maximale Dauer, die ein Kurs nach seinem Ende in EduPlanner sichtbar bleibt.';
$string['sett_sentrydsn_title'] = 'Sentry DSN';
$string['sett_sentrydsn_desc'] = 'Wohin Fehler-Debugging-Informationen gesendet werden sollen. (Bitte fragen Sie das Pallasys-Team nach einem Schlüssel)';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kürzer formulieren. vielleicht duzen.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$string['sett_sentrydsn_desc'] = 'Wohin Fehler-Debugging-Informationen gesendet werden sollen. (Bitte fragen Sie das Pallasys-Team nach einem Schlüssel)';
$string['sett_sentrydsn_desc'] = 'Zielort, an den Debug- und Fehlermeldungen übermittelt werden. (Bitte fragen Sie das Pallasys-Team nach einem Schlüssel)';

@RiedleroD RiedleroD requested a review from swewalka November 20, 2025 20:57
$string['lb_planner:teacher'] = 'LB Planner Lehrer';
$string['lb_planner:slotmaster'] = 'LB Planner Slotmaster';
// Settings
$string['sett_futuresight_title'] = 'Reservierungsbereich der Studenten';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zeitraum?

Suggested change
$string['sett_futuresight_title'] = 'Reservierungsbereich der Studenten';
$string['sett_futuresight_title'] = 'Reservierungszeitraum der Studenten';

$string['lb_planner:slotmaster'] = 'LB Planner Slotmaster';
// Settings
$string['sett_futuresight_title'] = 'Reservierungsbereich der Studenten';
$string['sett_futuresight_desc'] = 'Maximale Anzahl der Tage im Voraus, an denen Studenten Slots reservieren können. (0 = nur am selben Tag)';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$string['sett_futuresight_desc'] = 'Maximale Anzahl der Tage im Voraus, an denen Studenten Slots reservieren können. (0 = nur am selben Tag)';
$string['sett_futuresight_desc'] = 'Wie viele Tage im Voraus Studierende Termine/Slots buchen dürfen. (0 = nur am selben Tag)';

$string['sett_outdaterange_title'] = 'Veralteter Bereich der Kurse';
$string['sett_outdaterange_desc'] = 'Die maximale Dauer, die ein Kurs nach seinem Ende in EduPlanner sichtbar bleibt.';
$string['sett_sentrydsn_title'] = 'Sentry DSN';
$string['sett_sentrydsn_desc'] = 'Wohin Fehler-Debugging-Informationen gesendet werden sollen. (Bitte fragen Sie das Pallasys-Team nach einem Schlüssel)';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$string['sett_sentrydsn_desc'] = 'Wohin Fehler-Debugging-Informationen gesendet werden sollen. (Bitte fragen Sie das Pallasys-Team nach einem Schlüssel)';
$string['sett_sentrydsn_desc'] = 'Zielort, an den Debug- und Fehlermeldungen übermittelt werden. (Bitte fragen Sie das Pallasys-Team nach einem Schlüssel)';

// Settings
$string['sett_futuresight_title'] = 'Reservierungsbereich der Studenten';
$string['sett_futuresight_desc'] = 'Maximale Anzahl der Tage im Voraus, an denen Studenten Slots reservieren können. (0 = nur am selben Tag)';
$string['sett_outdaterange_title'] = 'Veralteter Bereich der Kurse';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$string['sett_outdaterange_title'] = 'Veralteter Bereich der Kurse';
$string['sett_outdaterange_title'] = 'Sichtbarkeitsdauer nach Kursende';

@mcquenji
Copy link
Contributor

@copilot implement the suggested changes

Co-authored-by: mcquenji <60017181+mcquenji@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 27, 2025

@copilot implement the suggested changes

Implemented all suggested changes in 36ed56c:

  • Line 38: "Reservierungsbereich" → "Reservierungszeitraum"
  • Line 39: Improved description wording
  • Line 40: "Veralteter Bereich der Kurse" → "Sichtbarkeitsdauer nach Kursende"
  • Line 41: "in EduPlanner" → "im EduPlanner"
  • Line 43: Improved Sentry DSN description

@RiedleroD
Copy link
Contributor

TODO:

  • check all german translations
  • remove italian translations (we will implement them later when @MasterMarcoHD has time)

@mcquenji
Copy link
Contributor

@copilot based on the requested changes earlier update other you made translations to fit thematically

Co-authored-by: mcquenji <60017181+mcquenji@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 28, 2025

@copilot based on the requested changes earlier update other you made translations to fit thematically

Done in 3121bc6. Updated all German translations with:

  • Shorter, more natural phrasing
  • Informal "du" form for user-facing messages
  • Removed Italian translations as requested by @RiedleroD

Copilot AI changed the title chore: Add German and Italian translations chore: Add German translations Nov 28, 2025
@RiedleroD RiedleroD merged commit 40a66c7 into EDUPL-154-translation Dec 2, 2025
1 check passed
@RiedleroD RiedleroD deleted the copilot/sub-pr-99 branch December 2, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants