Skip to content

Conversation

@RiedleroD
Copy link
Contributor

@RiedleroD RiedleroD commented Oct 4, 2025

closes EDUPL-26 impl sentry API for plugin

TODO:

  • adjust GHA to composer up on release
  • look at what config options are there
  • whatever these "spans" are that benji was talking about earlier

preliminary work for adding the sentry API to the plugin
@RiedleroD RiedleroD self-assigned this Oct 4, 2025
@RiedleroD
Copy link
Contributor Author

should work, still needs some polishing tho (e.g. setting configuration in ::init())

mcquenji pushed a commit that referenced this pull request Oct 9, 2025
`column` seems to be a reserved keyword in postgresql. really cool that
moodle never warned me of this.

anyway, this should fix EDUPL-19 if I'm correct.

this PR also:
- reverts previous change regarding extra debugging on this DB request
(it did its job and will be superseded by #89 later)
- reverts workarounds I put in place precisely so that I wouldn't have
to rename the field (postgres seems to have "interesting" behaviour
around inserting stuff without IDs)

do note that inside the code, the field in the \*model\* is still called
"column" - this is on one hand for brevity, and on the other so I don't
have to refactor as much.
@RiedleroD RiedleroD force-pushed the EDUPL-26-sentry-api branch from 9fb9987 to a569191 Compare October 9, 2025 19:50
@RiedleroD
Copy link
Contributor Author

thanks for the shitty backmerge github. real useless

@RiedleroD RiedleroD force-pushed the EDUPL-26-sentry-api branch from a569191 to 18eea0b Compare October 9, 2025 19:52
@RiedleroD RiedleroD self-assigned this Oct 29, 2025
@RiedleroD
Copy link
Contributor Author

RiedleroD commented Oct 30, 2025

this should be up & running on the testserver now.

After wrestling with moodle for 2h to make it un-bricked, I'm beat. Testing this tomorrow.

@RiedleroD RiedleroD requested a review from mcquenji October 30, 2025 02:58
@RiedleroD RiedleroD marked this pull request as ready for review November 10, 2025 22:01
Copy link
Contributor

@mcquenji mcquenji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RiedleroD RiedleroD merged commit 819d567 into main Nov 11, 2025
3 checks passed
@RiedleroD RiedleroD deleted the EDUPL-26-sentry-api branch November 11, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants