-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Sentry API integration #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
preliminary work for adding the sentry API to the plugin
|
should work, still needs some polishing tho (e.g. setting configuration in |
`column` seems to be a reserved keyword in postgresql. really cool that moodle never warned me of this. anyway, this should fix EDUPL-19 if I'm correct. this PR also: - reverts previous change regarding extra debugging on this DB request (it did its job and will be superseded by #89 later) - reverts workarounds I put in place precisely so that I wouldn't have to rename the field (postgres seems to have "interesting" behaviour around inserting stuff without IDs) do note that inside the code, the field in the \*model\* is still called "column" - this is on one hand for brevity, and on the other so I don't have to refactor as much.
9fb9987 to
a569191
Compare
|
thanks for the shitty backmerge github. real useless |
a569191 to
18eea0b
Compare
it's already included in moodle proper
this *should* work, but it's really hard to test, so… we'll see next release
|
this should be up & running on the testserver now. After wrestling with moodle for 2h to make it un-bricked, I'm beat. Testing this tomorrow. |
to protect from misspelling errors, and to have a semi-central place where all the keys are listed
mcquenji
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
closes EDUPL-26 impl sentry API for plugin
TODO:
composer upon release