[fix] Pressable suppression of contextmenu on windows #2316
Closed
yuxizhe wants to merge 2 commits intonecolas:masterfrom
Closed
[fix] Pressable suppression of contextmenu on windows #2316yuxizhe wants to merge 2 commits intonecolas:masterfrom
yuxizhe wants to merge 2 commits intonecolas:masterfrom
Conversation
yuxizhe
force-pushed
the
feat-windows-contextmenu
branch
2 times, most recently
from
d835c12 to
41ff24d
Compare
yuxizhe
changed the title
yuxizhe
changed the title
yuxizhe
force-pushed
the
feat-windows-contextmenu
branch
from
41ff24d to
3da3bbe
Compare
yuxizhe
force-pushed
the
feat-windows-contextmenu
branch
from
3da3bbe to
63521d0
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cc3f216:
|
Owner
|
I noticed codesandbox ci didn't replace the version for |
Contributor
Author
It seems we have to move this is my test: https://codesandbox.io/s/examples-858bn5?file=/package.json |
rnike
pushed a commit
to VeryBuy/react-native-web
that referenced
this pull request
Sep 13, 2022
Long-press with a touch on a Pressable does not suppress the contextmenu on Windows. On iOS and Android, the contextmenu is triggered while the pointer is down, after a certain length of time. However, on Windows, the contextmenu is displayed after pointerup (with the same timestamp as pointerup), whether triggered by a mouse right-click or a touch long-press. Fix necolas#2296 Close necolas#2316
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2296
Long-press with a touch on a Pressable does not suppress the contextmenu on Windows. On iOS and Android, the contextmenu is triggered while the pointer is down, after a certain length of time. However, on Windows, the contextmenu is displayed after pointerup (with the same timestamp as pointerup), whether triggered by a mouse right-click or a touch long-press.
before:
after:
