Update Appearance API to match RN's current Appearance API#2329
Closed
gksander wants to merge 2 commits intonecolas:masterfrom
Closed
Update Appearance API to match RN's current Appearance API#2329gksander wants to merge 2 commits intonecolas:masterfrom
Appearance API to match RN's current Appearance API#2329gksander wants to merge 2 commits intonecolas:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0a28cf1:
|
necolas
pushed a commit
that referenced
this pull request
Jul 6, 2022
Match react-native >=0.65 Fix #2329
rnike
pushed a commit
to VeryBuy/react-native-web
that referenced
this pull request
Sep 13, 2022
Match react-native >=0.65 Fix necolas#2329
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React Native has updated it's
AppearanceAPI to remove theAppearance.removeChangeListenerstatic method in favor ofAppearance.addChangeListenerreturning aremovemethod. See hereRight now, RNW and RN's implementations of
Appearanceare different and therefore use ofAppearanceAPI in modern RN projects will work on mobile, but will break with RNW. This PR addresses that issue by brining RNW'sAppearanceAPI up to spec with RN'sAppearanceAPI.