feat: Add Runtime MintGas syscall #4396
Conversation
Jim8y
changed the title
|
Transferring 0 NEO to self can achieve the same effect. |
roman-khimov
left a comment
roman-khimov
left a comment
There was a problem hiding this comment.
I don't understand why this complexity for a very simple thing. We have a (pretty much useless) System.Runtime.BurnGas() syscall, what we need is System.Runtime.MintGas() that would add it to the system fee and mint to caller (contract) address, that's about it. Then this fee is a part of the system fee, the user knows how much he spends for the overall transaction and contract gets the amount it needs.
| /// <summary> | ||
| /// The contract owner (deployer) script hash. | ||
| /// </summary> | ||
| public UInt160? Owner { get; set; } |
There was a problem hiding this comment.
I might misunderstand what we have discussed in the meeting, the first version i did is like what you mentioned, then i checked the NEP from chris again, and updated this pr accordingly. Will refactor this pr again based on your comments.
| if (amount.Sign < 0) | ||
| throw new InvalidOperationException("Fee amount cannot be negative."); | ||
|
|
||
| UInt160 beneficiary = fee.Beneficiary ?? contract.Manifest.Owner |
There was a problem hiding this comment.
Contract requires some fee, contract should be the receiver of it.
Jim8y
changed the title
|
@roman-khimov i think this one now addressed all your comments, may you please check again? now it only adds MintGas |
|
|
||
| var state = CurrentContext!.GetState<ExecutionContextState>(); | ||
| var wasWhitelisted = state.WhiteListed; | ||
| state.WhiteListed = false; |
| /// Minting GAS to benefit the current contract. | ||
| /// </summary> | ||
| /// <param name="amount">The amount of GAS to mint, in the unit of datoshi, 1 datoshi = 1e-8 GAS</param> | ||
| protected internal void MintGas(BigInteger amount) |
There was a problem hiding this comment.
Technically, it's not a minted, as it will only be used in this script. It can be considered minted, but it will be claimed and burned
There was a problem hiding this comment.
I think the syscall should be renamed to "ChargeGas"
There was a problem hiding this comment.
Minting gas would also be used in here neo-project/proposals#208
| { | ||
| state.WhiteListed = wasWhitelisted; | ||
| } | ||
| NativeContract.GAS.Mint(this, contract.Hash, amount, false).GetAwaiter().GetResult(); |
There was a problem hiding this comment.
This looks acceptable for N3, but not for N4 in my opnion
|
Seems related to neo-project/proposals#208 |
Summary
Testing