Apply SJH updates and remove deprecated members #38
Conversation
| ); | ||
| var jarContents = new JarContentsBuilder() | ||
| .paths(path) | ||
| .ignoreRootPackages("assets", "data") |
There was a problem hiding this comment.
Note: this skips scanning the assets and data folders of mods for classes... :)
| JarMetadata metadata = JarMetadata.from(new JarContentsBuilder().paths(path).build()); | ||
| metadata.providers().stream() |
There was a problem hiding this comment.
This greatly speeds up scanning for providers because we are not computing the packages anymore.
| } | ||
| try (var walk = Files.walk(modsDir, 1)){ | ||
| walk.forEach(ModDirTransformerDiscoverer::visitFile); | ||
| walk.parallel().forEach(ModDirTransformerDiscoverer::visitFile); |
There was a problem hiding this comment.
Walk in parallel to open file systems in parallel, should save some time too based on ATM9 profiles.
There was a problem hiding this comment.
Does this actually work (i.e. does Files.walk's stream actually support parallelism, or is it a no-op)? Usually I like to collect into a list first and then parallel stream that.
There was a problem hiding this comment.
Apparently this does not work because of a JDK bug that was only fixed in Java 19: https://bugs.openjdk.org/browse/JDK-8280915. Thanks for noticing...
|
Tested working with a few mods + a custom no-op |
loader/src/main/java/net/neoforged/fml/loading/ModDirTransformerDiscoverer.java
Outdated
Show resolved
Hide resolved
loader/src/main/java/net/neoforged/fml/loading/moddiscovery/ExplodedDirectoryLocator.java
Outdated
Show resolved
Hide resolved
4 participants
Depends on McModLauncher/securejarhandler#47.
The
IModFileInfocreation is still quite messy, but that will be for another time. :P