Support for enum extensions in jar generation#44
Open
lukebemish wants to merge 3 commits intoneoforged:mainfrom
Open
Support for enum extensions in jar generation#44lukebemish wants to merge 3 commits intoneoforged:mainfrom
lukebemish wants to merge 3 commits intoneoforged:mainfrom
Conversation
Note that this impl still requires FML at runtime; it's very pared down compared to RuntimeEnumExtender
Last commit published: 3344215924e3e84895f167d92a757e261402aac6 - version: PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name = "Maven for PR #44" // https://github.com/neoforged/InstallerTools/pull/44
url = uri("https://prmaven.neoforged.net/InstallerTools/pr44")
content {
includeModule("net.neoforged.installertools", "binarypatch-applier")
includeModule("net.neoforged.installertools", "binarypatcher")
includeModule("net.neoforged.installertools", "cli-utils")
includeModule("net.neoforged.installertools", "installertools")
includeModule("net.neoforged.installertools", "jarsplitter")
includeModule("net.neoforged.installertools", "problems-api")
includeModule("net.neoforged.installertools", "zipinject")
}
}
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this impl still requires FML load the same enum extensions at runtime; this will always be a requirement in order to maintain ordering guarantees and to avoid simply reimplementing RuntimeEnumExtender in its entirety. What it gives you otherwise though is the ability to compile against the entries (together with neoforged/JavaSourceTransformer#62 and company).