This repository was archived by the owner on Jul 29, 2024. It is now read-only.
Fix TypeScript import for Node16 module resolution mode#6
Open
msujew wants to merge 3 commits intonerdenough:mainfrom
Open
Fix TypeScript import for Node16 module resolution mode#6msujew wants to merge 3 commits intonerdenough:mainfrom
msujew wants to merge 3 commits intonerdenough:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5
For
"moduleResolution": "Node16"(i.e. native ESM imports), TypeScript requires atypesfield in theexportsobject. This change adds the required field.Additionally, it exports a few more types, which are very useful in case you actually want to propagate the expected argument types throughout your own adopter code. If unwanted, I can drop the commit again though.
Also fixes the type error related to the
fetchAPI.