fix: Use batch rpc to request result. Optimization sql search.#2530
Merged
Conversation
Contributor
yanguoyu
commented
Nov 19, 2022
yanguoyu
commented
- For the nerovs dao page, there are many rpc requests, use batch request.
- Because some users have many relations with others cells, left join twice to search inputs and outputs.
- Find unlock transactions with the status that equal Dead or Pending.
Keith-CY
reviewed
Nov 28, 2022
Keith-CY
reviewed
Dec 2, 2022
Keith-CY
approved these changes
Dec 2, 2022
Cedar67
approved these changes
Dec 29, 2022
Contributor
Cedar67
left a comment
Cedar67
left a comment
There was a problem hiding this comment.
Due to the changes to the ckb architecture, this PR needs to be validated after being merged into the develop branch.
1. For the nerovs dao page, there are many rpc requests, use batch request. 2. Because some users have many relations with others cells, left join twice to search inputs and outputs. 3. Find unlock transactions with the status that equal Dead or Pending.
yanguoyu
force-pushed
the
fix-batch-rpc
branch
from
517c099 to
3c4fc26
Compare
Contributor
Author
I have rebased develop. |
Keith-CY
reviewed
Dec 30, 2022
alexsupa597
approved these changes
Jan 3, 2023
Contributor
|
Verified on |
This was referenced May 27, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.