Skip to content

feat: Upgrade electron to 22.0.0#2544

Merged
Keith-CY merged 1 commit into
nervosnetwork:developfrom
yanguoyu:feat-update-electron
Jan 3, 2023
Merged

feat: Upgrade electron to 22.0.0#2544
Keith-CY merged 1 commit into
nervosnetwork:developfrom
yanguoyu:feat-update-electron

Conversation

@yanguoyu
Copy link
Copy Markdown
Contributor

@yanguoyu yanguoyu commented Dec 13, 2022

  1. Remove desktopCapturer from the renderer process.
  2. Set nodeIntegration to true because its default is false now.
  3. Update electron-log to 4.4.8 because it throws an unhandled promise reject in 4.0.0.

@yanguoyu yanguoyu mentioned this pull request Dec 13, 2022
Closed
@Cedar67
Copy link
Copy Markdown
Contributor

Cedar67 commented Dec 29, 2022

When click Nervos DAO, log displays an error message:

image

@yanguoyu yanguoyu force-pushed the feat-update-electron branch from c9d0c9b to ddaa84e Compare December 30, 2022 00:58
@yanguoyu
Copy link
Copy Markdown
Contributor Author

yanguoyu commented Dec 30, 2022

When click Nervos DAO, log displays an error message:

image

Can you expose the wallet public key, this problem may be related to the wallet.
I haven't received this problem.

@Cedar67
Copy link
Copy Markdown
Contributor

Cedar67 commented Dec 30, 2022

Can you expose the wallet public key, this problem may be related to the wallet.
I haven't received this problem.

Please check the attachment to obtain the public key:
Wallet AAA-xpubkey.json.zip

@yanguoyu
Copy link
Copy Markdown
Contributor Author

yanguoyu commented Dec 30, 2022

Can you expose the wallet public key, this problem may be related to the wallet.
I haven't received this problem.

Please check the attachment to obtain the public key: Wallet AAA-xpubkey.json.zip

I can't also reproduce this problem from your public key. From the screenshot, it causes by no unused address. Can you try to open your addresses page and find out whether there are no unused addresses?

@Keith-CY
Copy link
Copy Markdown
Contributor

Keith-CY commented Jan 3, 2023

How is it going @Cedar67

Cedar67
Cedar67 approved these changes Jan 3, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Cedar67 Cedar67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified.

@Keith-CY Keith-CY merged commit 474af2a into nervosnetwork:develop Jan 3, 2023
@yanguoyu yanguoyu deleted the feat-update-electron branch April 24, 2023 02:56
@Keith-CY Keith-CY mentioned this pull request May 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@Keith-CY Keith-CY Keith-CY approved these changes

@alexsupa597 alexsupa597 alexsupa597 approved these changes

@Cedar67 Cedar67 Cedar67 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yanguoyu @Cedar67 @Keith-CY @alexsupa597