fix: Sometimes RPC timeout but ckb is living#2574
Merged
Merged
Conversation
Contributor
yanguoyu
commented
Jan 18, 2023
yanguoyu
commented
- Try to check ckb is alive every 30s.
- When startCkb try to check the ckb is null.
1. Try to check ckb is alive every 30s. 2. When startCkb try to check the ckb is null.
Cedar67
approved these changes
Jan 19, 2023
Contributor
Cedar67
left a comment
Cedar67
left a comment
There was a problem hiding this comment.
Verified. No reproduction in five times.
Keith-CY
approved these changes
Jan 19, 2023
Contributor
|
I didn't find the reason for point 1 |
Contributor
Author
I think 10s is too faster, It's unnecessary. |
This was referenced Mar 1, 2023
This was referenced May 27, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.